This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
Jsonrpc backend refactor #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
`backends.jsonrpc` was already probably longer than it needed to be. I split
up the logic for `JSONRPCDaemon` and `JSONRPCWallet` in order to increase readibility.
This will be especially important in the future as more backends are written.
In particular, an issue (#73) is currently open which suggests adding MyMonero
API support. If this is added, it might be worth also adding the OpenMonero API.
Both of these are JSON RPC APIs, but I think it wouldn't necesarily make a lot
of sense to put these all into the same file so I went ahead and split the backends
up. Also, because of the default backends PR (#79), to the most basic of users, it
will matter much less how the backends are named, if you chose to take issue with
my naming. I hope this PR is useful for future development!
Changes:
1. Moved `JSONRPCDaemon` to `backends.rpcdaemon`
2. Moved `JSONRPCWallet` to `backends.rpcwallet`
3. Moved `jsonrpc` exceptions to `backends.rpcexceptions`
4. `monero.backends.jsonrpc` now only imports the backends and exceptions
5. Edited test files accordingly
Notes:
* This change is backwards compatible
emesik
force-pushed
the
jsonrpc_backend_refactor
branch
from
f7d5943
to
da23c8e
Compare
|
Looks good! Should the |
Merged
|
I'll update branches when releasing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of split