Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon can send duplicate transactions, causing disconnects #9335

Open
selsta opened this issue May 20, 2024 · 0 comments
Open

daemon can send duplicate transactions, causing disconnects #9335

selsta opened this issue May 20, 2024 · 0 comments
Assignees

Comments

@selsta
Copy link
Collaborator

selsta commented May 20, 2024

Since #8916 peers that send duplicate transactions gets dropped. This usually isn't an issue, but when running a daemon with --max-txpool-weight it's possible that duplicate transactions can get into the fluff queue.

Quoting @Boog900 from #9317 (comment)

If you receive a tx, add it to your fluff queue, drop the tx from the txpool, then receive it again, it is added to the fluff queue a second time. When the fluff timer fires we would then broadcast a message with the same tx twice causing the peer to disconnect.

Relevant code:

bool make_payload_send_txs(connections& p2p, std::vector<blobdata>&& txs, const boost::uuids::uuid& destination, const bool pad, const bool fluff)
{
epee::byte_slice blob = make_tx_message(std::move(txs), pad, fluff).finalize_notify(NOTIFY_NEW_TRANSACTIONS::ID);
return p2p.send(std::move(blob), destination);
}

@0xFFFC0000 0xFFFC0000 self-assigned this May 23, 2024
0xFFFC0000 added a commit to 0xFFFC0000/monero that referenced this issue Jun 3, 2024
0xFFFC0000 added a commit to 0xFFFC0000/monero that referenced this issue Jun 5, 2024
0xFFFC0000 added a commit to 0xFFFC0000/monero that referenced this issue Jun 5, 2024
1. Fix duplicate transaction monero-project#9335
2. Add test for cases where there are duplicate transaction in fluff

Co-authored-by: Boog900 <boog900@tutanota.com>
0xFFFC0000 added a commit to 0xFFFC0000/monero that referenced this issue Jun 6, 2024
1. Fix duplicate transaction monero-project#9335
2. Add test for cases where there are duplicate transaction in fluff

Co-authored-by: Boog900 <boog900@tutanota.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants