Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md: Heading capitalization and some cleanup #2881

Merged
merged 6 commits into from Dec 16, 2017
Merged

Readme.md: Heading capitalization and some cleanup #2881

merged 6 commits into from Dec 16, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2017

Most headings capitalized every word. A few did not. Now all do.

@moneromooo-monero
Copy link
Collaborator

I'd have thouhgt it'd be best to normalize NOT having capitals in the middle of sentences... We're not marketers :/

@ghost
Copy link
Author

ghost commented Dec 4, 2017

@moneromooo-monero
I totally agree. Was just following suit for what had already existed. I would prefer just the initial word of every heading be capitalized.

That said, the Bitcoin github capitalizes every word like we do. So there is precedent to keep things this way.

Shall I switch the readme to just having the first word capitalized?

@moneromooo-monero
Copy link
Collaborator

Meh, it's a fairly common way to do it too, so I don't really care all that much. The bitcoin github isn't a particularly authoritative model for something like this fwiw.

@ghost
Copy link
Author

ghost commented Dec 4, 2017

Edited with just first word capitalized. Let me know what you think.

@ghost
Copy link
Author

ghost commented Dec 4, 2017

A few suggestions:

  1. The "vulnerability response process" is listed twice, once at the top and another time under the Contributing header. Can one of them be removed?

  2. The header "Monero software updates and network consensus protocol upgrades (hard fork schedule)" seems like it could be shortened. What about "Monero network protocol upgrades (hard fork schedule)"? IE: removing the term "software updates" would shorten the whole thing a bit. Or we could even just label it "Monero hard fork schedule". Short and sweet. That's probably best. It calls it a network consensus protocol upgrade in the paragraph anyways.

@moneromooo-monero
Copy link
Collaborator

I personally prefer the new cap format, thanks :)

The second VRP paragraph seems entirely redundant indeed.

The long title is gingeropolous' construction, convince him :)

@Gingeropolous
Copy link
Collaborator

I don't care what the title is, as long as its just not "hard fork". I like the current title, obviously, because it explains things better than "hard fork".

perhaps it can just be "Network Consensus Protocol Upgrade "

and we can move "Software updates" into the title below.

@ghost
Copy link
Author

ghost commented Dec 5, 2017

Edited. Hopefully this looks good.

@ghost ghost changed the title Readme.md: Normalize heading capitalization Readme.md: Heading capitalization and some cleanup Dec 5, 2017
README.md Outdated

- Our [Vulnerability Response Process](https://github.com/monero-project/meta/blob/master/VULNERABILITY_RESPONSE_PROCESS.md) encourages responsible disclosure
- Our [vulnerability response process](https://github.com/monero-project/meta/blob/master/VULNERABILITY_RESPONSE_PROCESS.md) encourages responsible disclosure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VRP (and the adjectives which define the process) are defined as a proper noun. As such, the caps should stay.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ghost
Copy link
Author

ghost commented Dec 5, 2017

I don’t think there has been enough discussion to merge this one. We need at least 50 comments for a change this big.

@danrmiller
Copy link
Contributor

I don't really care, but I don't like "Network Consensus Protocol Upgrade" over hard fork, because the network protocol doesn't seem to affect consensus at all.

@Gingeropolous
Copy link
Collaborator

well it aint my fault bitcoin poisoned the notion of a hard fork.

aight then, Blockchain Inclusion Consensus Upgrade ... because it does change what is considered valid to be entered into the block.

whose riding dem bikes?

@danrmiller
Copy link
Contributor

I like "hard fork".

@ghost
Copy link
Author

ghost commented Dec 5, 2017

I prefer the heading be similar: Hard fork schedule

@lh1008
Copy link

lh1008 commented Dec 5, 2017

I prefer hard fork.. :)

@Gingeropolous
Copy link
Collaborator

aight, then you guys get to do all the explaining on reddit :)

@dEBRUYNE-1
Copy link
Contributor

dEBRUYNE-1 commented Dec 5, 2017

Fwiw, I used Scheduled Protocol Upgrade last time. I am not in favor of using the hard fork, as it might cause a lot of uproar. That is, the term hard fork currently has a quite negative connotation and is perceived as contentious.

@ghost
Copy link
Author

ghost commented Dec 5, 2017

After some discussion, people seem to agree on "Scheduled mandatory software upgrades" as the ideal heading for the section about scheduled hard forks. See recent commit and this discussion: https://paste.fedoraproject.org/paste/B~KljNfTRe1i2XFS0BgMFA

See the Readme in full @ https://github.com/xmr-eric/monero/tree/patch-4

jacobzipper pushed a commit to jacobzipper/monero-gui that referenced this pull request Dec 11, 2017
Recently the GUI repo had its name changed from monero-core to monero-gui. This PR updates the build instructions and elsewhere with the new repo name and link.

This PR also seeks to put the heading capitalization policy inline with the main Monero readme. Capitalizing every single word in a heading begins to feel redundant and cumbersome when headings become long (and many are indeed quite long). A much better practice is capitalizing just the initial word. See: monero-project/monero#2881
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit 41fc11f into monero-project:master Dec 16, 2017
fluffypony added a commit that referenced this pull request Dec 16, 2017
41fc11f Scheduled mandatory software upgrades (xmr-eric)
3b5382f Keep VRP a proper noun (xmr-eric)
7160cbd CONTRIBUTING.md capitalization (xmr-eric)
f36ffc0 Shorten a title, remove a section, small edits (xmr-eric)
0017991 Capitalization on first word only (xmr-eric)
6ffae07 Readme.md: Normalize heading capitalization (xmr-eric)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants