Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon RPC: add max_block_count field to /getblocks.bin #9381

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

j-berman
Copy link
Collaborator

Enables making parallel requests for a small number of blocks. When scanning the chain using parallel requests, setting this request param to a small number (e.g. 10) can speed up progress feedback to the user significantly (compared to leaving the default to 1000 as is).

Used in the Seraphis lib async scanner: UkoeHB#23

Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@iamamyth iamamyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, needs a rebase to remove the merge conflict.

@j-berman
Copy link
Collaborator Author

The conflict was from bumping the RPC minor version. Release branch current RPC minor version is 14. Master branch is 16. Resolved conflict by leaving it untouched at 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants