Support PHP 8.3 #757
Closed
Support PHP 8.3 #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frederikbosch I know you're probably busy, but PHP 8.3 will be released this month and this is blocking our project from being tested on the new version. Could you please merge and tag? Thank you! |
|
Thanks for the at-mention. I was not aware of this. Why isn't this generating any actions? |
|
Probably a bug in GitHub Actions. Needs a force push. |
ruudk
added a commit
to ruudk/composer-dangling-commit-reproducer
that referenced
this pull request
Nov 17, 2023
I'm installing a commit from this PR moneyphp/money#757 It does work, but it still fails to install on PHP 8.3, because Composer is using dev-master as a reference point to find the (platform) dependencies. Instead of reading it from the commit.
|
Thanks, superseded by #760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.