Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation option #2

Closed
ghost opened this issue Dec 19, 2020 · 2 comments
Closed

Orientation option #2

ghost opened this issue Dec 19, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Dec 19, 2020

Add orientation option, press to open dialog box, add this four option

  • portrait, landscape, device and sensor orientation. Set any of this 4, set 1 to be default.

NOTE: REPLACE SUBTITLE FOLDER TO ORIENTATION BUTTON.

PUT SUBTITLE FOLDER TO ( >) INSIDE SETTING CONTAIN OPTION.
ghjj

@moneytoo moneytoo changed the title Suggestion Orientation option Dec 19, 2020
@moneytoo
Copy link
Owner

This is my current priority and I already started working on it. My idea of possible rotation options is:

  • System/user rotation
  • Orientation based on video content (landscape/portrait)
  • Auto/sensor rotation (skip it if system auto rotation is already enabled?)

I have found out that I will need to possibly rework how the buttons work in the bottom bar as ExoPlayer manages hiding/showing them.

@moneytoo moneytoo added the enhancement New feature or request label Dec 19, 2020
@moneytoo moneytoo self-assigned this Dec 19, 2020
@moneytoo
Copy link
Owner

Action for rotate options added in version 0.10. I ended up with only two options: "Video orientation" and "Auto-rotate". I'm not necessarily agains more options but I want to try keeping it minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant