Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce button sizes from Bootstrap's oversized defaults for improved aesthetics #1456

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: reduce button sizes from Bootstrap's oversized defaults for improved aesthetics #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
360e3a7
Reduced button sizes from Bootstrap's oversized defaults for improved…
afridsyed326 Mar 12, 2024
b70af8a
new
Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@
"file-loader": "^6.2.0",
"jquery": "^3.7.1",
"mocha": "^10.3.0",
"nyc": "^15.1.0",
"mongodb-memory-server": "^9.1.6",
"node-html-parser": "^6.1.12",
"nodemon": "^3.1.0",
"nyc": "^15.1.0",
"popper.js": "^1.16.1",
"pre-commit": "1.2.2",
"renderjson": "github:rtritto/renderjson#develop",
Expand Down
9 changes: 9 additions & 0 deletions public/stylesheets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,12 @@
border-radius: 4px; /* future proofing */
-khtml-border-radius: 4px; /* for old Konqueror browsers */
}

.btn {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overwriting all .btn styles with !important is not the best idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed! It would be better create another class and not overwrite bootstrap's classes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make this, so I can merge it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jchabrowski Thank you for the suggestion. I Will make it . @shakaran

Copy link
Contributor

@xTudoS xTudoS Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afridsyed326 You could try just reducing the number of columns that this buttons are using to one instead of two.

image

padding: 8px !important;
display: flex !important;
width: fit-content !important;
justify-content: center !important;
align-items: center !important;;
gap: 10px !important;
}