feat(compass-workspace): breadcrumbs COMPASS-7593 #5501
Conversation
| return ( | ||
| <div | ||
| title={`${database}.${collection}`} |
There was a problem hiding this comment.
Nit: you already have a "composed" namespace here
| title={`${database}.${collection}`} | |
| title={namespace} |
There was a problem hiding this comment.
I'd be remove this completely as it adds title to the whole breadcrumb and the badges within this div.
| export const Breadcrumbs = ({ items }: { items: Array<BreadcrumbItem> }) => { | ||
| const darkMode = useDarkMode(); | ||
| return ( | ||
| <div className={breadcrumbStyles} data-testid="breadcrumbs"> |
There was a problem hiding this comment.
We probably want to have some sort of overflow control here:
There was a problem hiding this comment.
Resolved in 7f402b9
| <> | ||
| <Link | ||
| key={item.name} | ||
| as="a" |
There was a problem hiding this comment.
Because we're not handling this as a link and there's no url, this should be as button, right?
| as="a" | |
| as="button" |
| const breadcrumbItems = useMemo(() => { | ||
| return [ | ||
| { | ||
| // TODO (COMPASS-7684): add connection name |
There was a problem hiding this comment.
Not sure if it's worth discussing with design, but while we wait for the multiconnection work to handle this, maybe we can hide it for now?
There was a problem hiding this comment.
I'll check it with the design and update this (and the todo ticket) accordingly.
There was a problem hiding this comment.
I removed it from this PR in this b95a406. I added this for reference in the ticket. So now we are only showing breadcrumb on the collection-header, without Cluster
…nto breadcrumbs
…nto breadcrumbs
| name: toNS(namespace).collection, | ||
| onClick: () => openCollectionWorkspace(namespace), | ||
| }, | ||
| // When editing a view, show the view namespace last |
There was a problem hiding this comment.
Not sure if it's something that needs addressing, but just want to call out that this logic doesn't match the logic in the workspace tab breadcrumb. Do we need to update it too?
There was a problem hiding this comment.
That's a really good point. I'll check with design and if needed create a follow up.
| collectionMetadata.isTimeSeries || | ||
| collectionMetadata.sourceName || | ||
| editViewName; | ||
| if (!hideStats && tab.name === 'Documents') { |
There was a problem hiding this comment.
Super nit, if you first check for hideStats, you don't need to do it here and in the check below, seems to be that it reads a bit easier that way:
if (alwaysHideStats) {
return tab.name;
}
if (tab.name === 'Documents') {
...
This PR adds breadcrumbs to Compass workspace. It also remove collection information from the header and its shown now in the corresponding tab names (see video).
Workspace Breadcrumbs
Screen.Recording.2024-02-26.at.23.21.17.mov
Collection Meta
Screen.Recording.2024-02-26.at.23.22.38.mov
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes