Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crud): don't render the Save button if there is no favourite query storage COMPASS-7679 #5511

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Feb 28, 2024

No description provided.

@lerouxb lerouxb added the no release notes Fix or feature not for release notes label Feb 28, 2024
@github-actions github-actions bot added the fix label Feb 28, 2024
@paula-stacho
Copy link
Contributor

out of curiosity - in what situation would the query storage not be available?

@lerouxb
Copy link
Contributor Author

lerouxb commented Feb 28, 2024

@paula-stacho in compass-web, ie. for now when compass-web lands in Data Explorer. Same thing already for the recent queries and favourites accessed from querybar.

@himanshusinghs
Copy link
Contributor

Thank you 🚀 I missed this one.

@lerouxb lerouxb merged commit 569128a into main Mar 1, 2024
16 checks passed
@lerouxb lerouxb deleted the disable-save-query-web branch March 1, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants