Skip to content
This repository has been archived by the owner on May 31, 2022. It is now read-only.

chore: remove kerberos password COMPASS-4378 #343

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

rose-m
Copy link
Contributor

@rose-m rose-m commented Jan 19, 2021

Description

Removes the Kerberos password field from the connection model.
Also bumps mongodb-runner to the latest version to make it work on Node 14.x.

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@rose-m rose-m self-assigned this Jan 19, 2021
Copy link
Contributor

@mcasimir mcasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! what would happen when a connection is loaded and there was a kerberos password?

@rose-m
Copy link
Contributor Author

rose-m commented Jan 19, 2021

@mcasimir I've added a tiny test to at least ensure the parsing of old-style URLs with passwords works and when you transform again to URL it's gone.

@rose-m rose-m merged commit a8ef198 into master Jan 19, 2021
@rose-m rose-m deleted the COMPASS-4378-remove-kerberos-password branch January 19, 2021 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants