Skip to content

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Oct 1, 2025

Description

Summary of Changes

This PR switches from ubuntu to rhel8 for glibc-based prebuilds.

We always test on all Node versions, but only build and publish prebuilds on our lowest LTS Node version. Prior to upgrading to Node20+, we built prebuilds on Node16 and ubuntu bionic, with a glibc version of 2.27. After upgrading to Node20+, we switch prebuilds from ubuntu bionic to ubuntu noble. Ubuntu noble has a glibc version of 2.39, which meant our prebuilds in the 7.0.0-alpha release were incompatible with any versions of linux that have a lower glibc version.

Since there isn't an ubuntu version that ships with libc 2.28 and supports Node 20+, I switched CI to run on rhel8 with satisfies our glibc requirement.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review October 2, 2025 17:36
@baileympearson baileympearson requested a review from a team as a code owner October 2, 2025 17:36
@baileympearson baileympearson changed the title test rhel80 builds fix(NODE-7225): build glibc prebuilds on rhel8 Oct 2, 2025
@baileympearson baileympearson changed the title fix(NODE-7225): build glibc prebuilds on rhel8 fix(NODE-7225): build glibc prebuilds on platforms with libc 2.28 Oct 2, 2025
@dariakp dariakp self-assigned this Oct 2, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 2, 2025
@baileympearson baileympearson requested a review from dariakp October 2, 2025 19:00
@dariakp dariakp merged commit 503df19 into main Oct 2, 2025
28 checks passed
@dariakp dariakp deleted the test-rhel8-builds branch October 2, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants