This repository was archived by the owner on Feb 4, 2022. It is now read-only.
fix(error): attach command response to MongoWriteConcernError #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NODE-1521
daprahamian
suggested changes
Jun 20, 2018
lib/error.js
Outdated
| const MongoWriteConcernError = function(message) { | ||
| MongoError.call(this, message); | ||
| const MongoWriteConcernError = function(message, result) { | ||
| MongoError.call(this, message, result); |
There was a problem hiding this comment.
Why do we need to pass result to MongoError? It doesn't appear to do anything with it.
There was a problem hiding this comment.
oops, thanks for catching that!
lib/connection/pool.js
Outdated
| @@ -581,6 +581,13 @@ function messageHandler(self) { | |||
| } | |||
|
|
|||
| if (responseDoc.writeConcernError) { | |||
| if (responseDoc.ok === 1) { | |||
There was a problem hiding this comment.
What about doing a ternary to create the error, and then using a single callback?
if (responseDoc.writeConcernError) {
const err = responseDoc.ok === 1 ?
new MongoWriteConcernError(responseDoc.writeConcernError, responseDoc) :
new MongoWriteConcernError(responseDoc.writeConcernError);
return handleOperationCallback(self, workItem.cb, err);
}
daprahamian
approved these changes
Jun 20, 2018
mbroadst
suggested changes
Jun 21, 2018
lib/error.js
Outdated
| @@ -131,12 +131,17 @@ function isRetryableError(error) { | |||
| * @class | |||
| * @param {Error|string|object} message The error message | |||
| * @property {string} message The error message | |||
| * @property {object} result The result document (provided if ok: 1) | |||
There was a problem hiding this comment.
Please wrap the name of the argument with brackets to indicate it is optional, and add it to the @param documentation.
mbroadst
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NODE-1521