Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Pass global set proxy settings to mongodb-download #21

Closed
wants to merge 1 commit into from
Closed

Pass global set proxy settings to mongodb-download #21

wants to merge 1 commit into from

Conversation

thisispax
Copy link

This pull request passes the global set proxy settings to mongodb-download. So as mentioned in this issue (#20) a download through a corporate proxy will be possible.

@winfinit
Copy link
Contributor

mongodb-download allows you to pass opts, to that you can pass agent and your own proxy object

@thisispax
Copy link
Author

mongoose uses mongodb-prebuilt to get mongodb. but that doesn't work for me because of our proxy... so what would you suggest to do?

@BenCoffman
Copy link

@pax1878 👍

Please merge @winfinit

@YellowDarter
Copy link

Having exactly the same problem as @pax1878 - The npm install for mongodb-prebuilt automatically calls mongodb-download, without the ability to pass in the opts anywhere. @pax1878 's code solves this by using the system-wide proxy environment variable.

Please accept the pull as it will only impact those with the proxy variable set and works well in our testing.

@winfinit
Copy link
Contributor

@BenCoffman and @pax1878, I've released new version of Mockgoose 6.0.0 there are small modifications to your unit tests that you would have to do, but it will save you a lot of headache in the future, if you will convert to 6.0 release, that also incorporates requested feature here.

https://www.npmjs.com/package/mongodb-prebuilt#download-proxy

@thisispax
Copy link
Author

Thanks a lot for your help!

@thisispax thisispax closed this Apr 1, 2016
@BenCoffman
Copy link

#winning 👍

@thisispax thisispax deleted the pass_proxy branch April 7, 2016 08:12
t1bb4r pushed a commit to t1bb4r/mongodb-prebuilt that referenced this pull request Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants