-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(MONGOSH-1808): migrate mongosh to new mongodb-client-encryption repository #2023
Conversation
v6.0.0 and v6.0.1 tags in the other repo do not have a working version of the download/build script. This PR should be picked up once we have tagged and released from the new repo. |
187a815
to
444af71
Compare
Currently blocked on (evg patch):
|
I think it's not complaining about the value of These flags are coming from here: https://github.com/mongodb-js/mongodb-client-encryption/blob/95849ddca9a452b1f697189a29a483d354a394bd/binding.gyp#L27-L33 – they should probably be in the
Fwiw, we happily adjust our build |
Good call on the -arch flag being split up. I'll look into that, but I don't think that it should be in the "dynamic" section, IIUC that is unused, we build static prebuilds and we're trying to build statically for mongosh here. It would be nice if I could somehow feature detect, but maybe I can add a new variable we pipe in for our prebuilds to set -arch and otherwise it is omitted. I will investigate further. |
An update, so I've enabled the ability to only build for the specific macos platform, however, even when only building for the local platform node-gyp is still putting Window, still need to find a newer cmake version, haven't started on that. I don't want to have to download it but may have to. |
A lot of red but none of them are compile_artifact 🎉 |
Closing in favour of #2076 |
Changes prep-fle-addon script to use new repo and depend on new repo's script for downloading/building bindings. The version of libmongocrypt is now determined by the binding's package.json file.