feat: allow dynamic async/rejectable allowedFlows COMPASS-6811 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should enable us to display a modal in Compass when re-authentication is required after the initial auth, and prompt the user whether they want to reauthenticate or just return to the connection screen again.
addaleax
commented
May 12, 2023
| // openid-client bases expiration time on the actual current time, so | ||
| // allow for a small margin of error | ||
| expect(timeouts[0].timeout).to.be.greaterThanOrEqual(9_600_000); | ||
| expect(timeouts[0].timeout).to.be.lessThanOrEqual(9_800_000); |
There was a problem hiding this comment.
(This is unrelated, the test just failed on an earlier version of this PR)
gribnoysup
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable us to display a modal in Compass when re-authentication is required after the initial auth, and prompt the user whether they want to reauthenticate or just return to the connection screen again.