Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Add storage engine option to direct invocation of runner #74

Merged
merged 1 commit into from
May 19, 2016

Conversation

TylerBrock
Copy link
Contributor

@TylerBrock TylerBrock commented May 18, 2016

Closes #73


This change is Reviewable

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @imlucas, @judahschvimer and @kangas to be potential reviewers

@TylerBrock
Copy link
Contributor Author

Also would be great if we could cut a new release with this and publish to NPM so we can use it for the test matrix in parse-server.

@TylerBrock
Copy link
Contributor Author

I'm not sure why tests don't pass, maybe a timeout issue. They all pass on Linux here where I'm testing.

@imlucas
Copy link
Contributor

imlucas commented May 19, 2016

:lgtm:

Previously, TylerBrock (Tyler Brock) wrote…

I'm not sure why tests don't pass, maybe a timeout issue. They all pass on Linux here where I'm testing.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@imlucas imlucas merged commit f951fd5 into mongodb-js:master May 19, 2016
@imlucas
Copy link
Contributor

imlucas commented May 19, 2016

published in mongodb-runner@3.3.0

@imlucas
Copy link
Contributor

imlucas commented May 19, 2016

#54 is desperately needed and will resolve flakey test issue above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants