Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ahash from 0.7.6 to 0.8.3 #414

Merged
merged 2 commits into from
May 16, 2023
Merged

update ahash from 0.7.6 to 0.8.3 #414

merged 2 commits into from
May 16, 2023

Conversation

Liyixin95
Copy link
Contributor

No description provided.

@abr-egn abr-egn self-requested a review May 9, 2023 14:11
@abr-egn
Copy link
Contributor

abr-egn commented May 9, 2023

Thanks for contributing! I've kicked off the evergreen run and assuming that passes I'll merge this in.

@abr-egn
Copy link
Contributor

abr-egn commented May 15, 2023

Sorry for the delay!

It looks like (for reasons I don't currently understand) versions 0.8.1 and above of ahash don't work with our MSRV, so I've updated your PR only bump the dependency to 0.8.0, and added a lockfile needed for our MSRV testing. Does that work for you?

@Liyixin95
Copy link
Contributor Author

Does that work for you?

of course.

It looks like (for reasons I don't currently understand) versions 0.8.1 and above of ahash don't work with our MSRV.

the msrv of ahash version 0.8.3 is 1.6.0, which they do not indicate in their project.

The specific reason is namespaced-features

In their project looks like:

atomic-polyfill = [ "dep:atomic-polyfill", "once_cell/atomic-polyfill"]

@abr-egn abr-egn merged commit 818e90f into mongodb:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants