Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixes ldap config to allow PATCH #340

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix: fixes ldap config to allow PATCH #340

merged 1 commit into from
Jan 9, 2023

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Jan 9, 2023

Description

Fixes #339

This will be a breaking change but it's necessary to correct the reported issue

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@gssbzn gssbzn added the breaking Pull requests that breaks backwards compatibility label Jan 9, 2023
@gssbzn gssbzn requested a review from a team as a code owner January 9, 2023 15:36
andreaangiolillo
andreaangiolillo approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn
Copy link
Collaborator Author

gssbzn commented Jan 9, 2023

FYI @Zuhairahmed since this may have impact for terraform and/or CFN

@gssbzn gssbzn merged commit 4edbe98 into master Jan 9, 2023
@gssbzn gssbzn deleted the 339 branch January 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
breaking Pull requests that breaks backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set the "authenticationEnabled" = false using the client.LDAPConfigurations.Save()
2 participants
@gssbzn @andreaangiolillo