fix(NODE-3582): fix internal marked APIs, add toString methods to Int32 and Double #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addaleax I'd appreciate a review if you have the time (at-ing since I can't request directly) |
addaleax
approved these changes
Sep 1, 2021
dariakp
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of the convenience helpers, toString and toJSON marked as internal on our Type classes. The should be made available in our type definitions.
Additionally we were missing toString methods for Int32 and Double, I think its unexpected that these would return
[object Object]for toString.I can revert if we want to do this seperately.