Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-6017): add an s390x big endian test #660

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Add a zSeries task that specifically runs the big endian test
  • Temporary solution to make sure our change actually fixes the bug and no further regressions
Is there new documentation needed for these changes?

No.

What is the motivation for this change?

  • Inspect what we expect

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken
Copy link
Contributor Author

@nbbeeken nbbeeken marked this pull request as ready for review March 12, 2024 19:32
@W-A-James W-A-James self-assigned this Mar 12, 2024
@W-A-James W-A-James self-requested a review March 12, 2024 19:33
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 12, 2024
@W-A-James W-A-James merged commit c910db1 into main Mar 12, 2024
5 checks passed
@W-A-James W-A-James deleted the NODE-6017-s390x branch March 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants