-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6156): add signature to github releases #692
Conversation
3896b22
to
df748cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
One other note - Looks like only the release tarball (no signature file) is upload: https://github.com/mongodb/js-bson/actions/runs/9195659055
@baileympearson If you click on the bson-6.6.0.tar.gz file, it contains a bson-6.6.0.tar.gz.sig file within |
@aditi-khare-mongoDB Oh, you're right! Nice. Is is possible to upload them separately? I don't know if it matters much, but I think we should shoot for something similar to what devtools has for their repos, where the signatures are attached separate from the file. Here's an example: https://github.com/mongodb-js/compass/releases/tag/v1.43.0 |
Jumping in here, yeah I also expected the .sig to be a "top-level" artifact and that the only tgz would be the one that can be obtained from npm view bson@latest dist.tarball When automating this, I'll want to replace "latest" with something like With that, I can get the tar url, a bit of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add release highlights, otherwise LGTM
d213e51
to
0634629
Compare
Description
Sign releases in both 5.x and 6.x
What is changing?
Automate release signing with a detached signature and verification instructions in the README.
Example Signature Link: https://github.com/mongodb/js-bson/actions/runs/9195659055
Is there new documentation needed for these changes?
No
What is the motivation for this change?
SSDLC Compliance
Release Highlight
Add Signature to Github Releases
The Github release for
js-bson
now contains a detached signature file for the NPM package (namedbson-X.Y.Z.tgz.sig
), on every major and patch release to 6.x and 5.x. To verify the signature, follow the instructions in the 'Release Integrity' section of theREADME.md
file.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript