Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] add escape regex chars to DB Presence Verifier #1992

Merged
merged 8 commits into from
Dec 4, 2020
Merged

[3.x] add escape regex chars to DB Presence Verifier #1992

merged 8 commits into from
Dec 4, 2020

Conversation

andrei-gafton-rtgt
Copy link
Contributor

@andrei-gafton-rtgt andrei-gafton-rtgt commented Mar 9, 2020 •
edited
Loading

add preg_quote to value in getCount for Unique validation with DatabasePresenceVerifier.php in order to correctly escape regex chars in values from DB (eg. "+")

@jenssegers
Copy link
Contributor

jenssegers commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #1992 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1992   +/-   ##
=========================================
  Coverage     86.75%   86.75%           
  Complexity      666      666           
=========================================
  Files            31       31           
  Lines          1518     1518           
=========================================
  Hits           1317     1317           
  Misses          201      201
Impacted Files Coverage Δ Complexity Δ
...rs/Mongodb/Validation/DatabasePresenceVerifier.php 76.92% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279b18c...eae84ce. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #1992 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1992   +/-   ##
=========================================
  Coverage     87.04%   87.04%           
  Complexity      667      667           
=========================================
  Files            31       31           
  Lines          1521     1521           
=========================================
  Hits           1324     1324           
  Misses          197      197
Impacted Files Coverage Δ Complexity Δ
...rs/Mongodb/Validation/DatabasePresenceVerifier.php 76.92% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7acac7...3811c65. Read the comment docs.

@Smolevich
Copy link
Contributor

…h regex

@andrei-gafton-rtgt, Update description please

@andrei-gafton-rtgt andrei-gafton-rtgt changed the title add preg_quote to value checks in get Count for Unique validation wit… add escape regex chars to DB Presence Verifier Mar 10, 2020
@Smolevich
Copy link
Contributor

@andrei-gafton-rtgt add additional test case for this PR

@divine divine changed the title add escape regex chars to DB Presence Verifier [3.x] add escape regex chars to DB Presence Verifier Mar 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2020 •
edited
Loading

Codecov Report

Merging #1992 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1992   +/-   ##
=========================================
  Coverage     86.90%   86.90%           
  Complexity      664      664           
=========================================
  Files            33       33           
  Lines          1573     1573           
=========================================
  Hits           1367     1367           
  Misses          206      206
Impacted Files Coverage Δ Complexity Δ
...rs/Mongodb/Validation/DatabasePresenceVerifier.php 76.92% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6f667...79b22f1. Read the comment docs.

@divine
Copy link
Contributor

divine commented Sep 14, 2020

@Smolevich anything is left here?

@codecov-io
Copy link

codecov-io commented Dec 4, 2020 •
edited
Loading

Codecov Report

Merging #1992 (f92da85) into master (a9c7410) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1992   +/-   ##
=========================================
  Coverage     87.01%   87.01%           
  Complexity      664      664           
=========================================
  Files            33       33           
  Lines          1556     1556           
=========================================
  Hits           1354     1354           
  Misses          202      202
Impacted Files Coverage Δ Complexity Δ
...rs/Mongodb/Validation/DatabasePresenceVerifier.php 76.92% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c7410...f92da85. Read the comment docs.

@divine divine removed the Needs work label Dec 4, 2020
@Smolevich Smolevich merged commit 958c4ed into mongodb:master Dec 4, 2020
divine added a commit to divine/laravel-mongodb that referenced this pull request Dec 17, 2020
@divine
Add mongodb#1992 to changelog
76c46f8
divine added a commit to divine/laravel-mongodb that referenced this pull request Dec 17, 2020
@divine @andrei-gafton-rtgt
Backport of mongodb#1992 to 3.6
97b0ed2 
Add preg_quote to value in getCount for Unique validation with DatabasePresenceVerifier.php in order to correctly escape regex chars in values from DB (eg. "+")

Co-Authored-By: andrei-gafton-rtgt <61140282+andrei-gafton-rtgt@users.noreply.github.com>
@divine divine mentioned this pull request Dec 17, 2020
Merged
divine added a commit to divine/laravel-mongodb that referenced this pull request Dec 17, 2020
@divine @andrei-gafton-rtgt
Backport of mongodb#1992 to 3.7
4f3f0b8 
Add escape regex chars to DB Presence Verifier [mongodb#1992](mongodb#1992) by [@andrei-gafton-rtgt](https://github.com/andrei-gafton-rtgt).

Co-Authored-By: andrei-gafton-rtgt <61140282+andrei-gafton-rtgt@users.noreply.github.com>
divine added a commit that referenced this pull request Dec 17, 2020
@divine
Merge pull request #2153 from divine/add_escape_3_6
142876d 
[3.6] Backport of #1992 to 3.6
@divine divine mentioned this pull request Dec 17, 2020
Merged
divine added a commit that referenced this pull request Dec 18, 2020
@divine
Merge pull request #2154 from divine/add_escape_3_7
7a309ef 
[3.7] Backport of #1992 to 3.7
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert
Merge pull request mongodb#1992 from andrei-gafton-rtgt/master
faf92fb 
[3.x] add escape regex chars to DB Presence Verifier
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
@mnphpexpert
Add mongodb#1992 to changelog
4d9ddb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divine divine divine approved these changes

@Smolevich Smolevich Smolevich approved these changes

Assignees

@andrei-gafton-rtgt andrei-gafton-rtgt

Labels
candidate-for-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrei-gafton-rtgt @jenssegers @codecov-io @Smolevich @codecov-commenter @divine