Support renaming columns in migrations #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hans-thomas
commented
Nov 19, 2023
Comment on lines
+280
to
+287
| /** @inheritdoc */ | ||
| public function renameColumn($from, $to) | ||
| { | ||
| $this->collection->updateMany([$from => ['$exists' => true]], ['$rename' => [$from => $to]]); | ||
|
|
||
| return $this; | ||
| } | ||
|
|
There was a problem hiding this comment.
First, it finds the documents that have the $from column and then runs a query to rename their column to the $to.
alcaeus
approved these changes
Nov 20, 2023
alcaeus
changed the title
GromNaN
approved these changes
Nov 21, 2023
This reverts commit 7d6f87d.
|
Thank you @hans-thomas |
Treggats
pushed a commit
to Treggats/laravel-mongodb
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2391
As mentioned in the linked issue, the
renameColumndoesn't work. I just override that to fix the method.