Skip to content

Commit

Permalink
GODRIVER-2826 Clean up TODOs in comments. (#1243)
Browse files Browse the repository at this point in the history
  • Loading branch information
qingyang-hu committed May 2, 2023
1 parent 374e369 commit 2d6b603
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions x/bsonx/bsoncore/value.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ func (v Value) IsNumber() bool {

// AsInt32 returns a BSON number as an int32. If the BSON type is not a numeric one, this method
// will panic.
//
// TODO(skriptble): Add support for Decimal128.
func (v Value) AsInt32() int32 {
if !v.IsNumber() {
panic(ElementTypeError{"bsoncore.Value.AsInt32", v.Type})
Expand Down Expand Up @@ -93,8 +91,6 @@ func (v Value) AsInt32() int32 {

// AsInt32OK functions the same as AsInt32 but returns a boolean instead of panicking. False
// indicates an error.
//
// TODO(skriptble): Add support for Decimal128.
func (v Value) AsInt32OK() (int32, bool) {
if !v.IsNumber() {
return 0, false
Expand Down Expand Up @@ -127,8 +123,6 @@ func (v Value) AsInt32OK() (int32, bool) {

// AsInt64 returns a BSON number as an int64. If the BSON type is not a numeric one, this method
// will panic.
//
// TODO(skriptble): Add support for Decimal128.
func (v Value) AsInt64() int64 {
if !v.IsNumber() {
panic(ElementTypeError{"bsoncore.Value.AsInt64", v.Type})
Expand Down Expand Up @@ -162,8 +156,6 @@ func (v Value) AsInt64() int64 {

// AsInt64OK functions the same as AsInt64 but returns a boolean instead of panicking. False
// indicates an error.
//
// TODO(skriptble): Add support for Decimal128.
func (v Value) AsInt64OK() (int64, bool) {
if !v.IsNumber() {
return 0, false
Expand Down

0 comments on commit 2d6b603

Please sign in to comment.