GODRIVER-3038 Apply CSE to IndexView operations #1636
Conversation
API Change ReportNo changes found! |
| }) | ||
| } | ||
|
|
||
| func TestFLEIndexView(t *testing.T) { |
There was a problem hiding this comment.
@kevinAlbs Would this be a good candidate as an optional FLE prose test for drivers that support index view?
There was a problem hiding this comment.
libmongocrypt bypasses listIndexes and dropIndexes. The commands are returned as-is since the commands are not expected to contain values needing encryption.
I still agree with this PR. I think it is slightly preferable to process these commands with libmongocrypt for consistency with other commands. But I expect it is not strictly necessary, since the caller would not observe a difference when processing with libmongocrypt.
Since I expect is no observable behavior difference when processing listIndexes and dropIndexes with libmongocrypt, and a prose test may rely on private API that is not consistent among all drivers, I recommend against pursuing a prose test for all drivers.
| }) | ||
| } | ||
|
|
||
| func TestFLEIndexView(t *testing.T) { |
There was a problem hiding this comment.
libmongocrypt bypasses listIndexes and dropIndexes. The commands are returned as-is since the commands are not expected to contain values needing encryption.
I still agree with this PR. I think it is slightly preferable to process these commands with libmongocrypt for consistency with other commands. But I expect it is not strictly necessary, since the caller would not observe a difference when processing with libmongocrypt.
Since I expect is no observable behavior difference when processing listIndexes and dropIndexes with libmongocrypt, and a prose test may rely on private API that is not consistent among all drivers, I recommend against pursuing a prose test for all drivers.
prestonvasquez
dismissed stale reviews from qingyang-hu and kevinAlbs
via
e31ebbd
GODRIVER-3038
Summary
Add FLE support to IndexView.List and IndexView.Crypt
Background & Motivation