Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in docs #1285

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix syntax error in docs #1285

merged 1 commit into from
Apr 23, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Apr 23, 2024

Fixes #1284.

@alcaeus alcaeus requested a review from GromNaN April 23, 2024 07:03
@alcaeus alcaeus self-assigned this Apr 23, 2024
@alcaeus alcaeus requested a review from a team as a code owner April 23, 2024 07:03
@alcaeus alcaeus mentioned this pull request Apr 23, 2024
Closed
@alcaeus alcaeus linked an issue Apr 23, 2024 that may be closed by this pull request
Docs: missing ] character in database->aggregate documentation #1284
Closed
GromNaN
GromNaN approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's stopping us from extracting all the examples into PHP files?

@alcaeus
Copy link
Member Author

alcaeus commented Apr 23, 2024

What's stopping us from extracting all the examples into PHP files?

Mainly time, but this is definitely something to consider for when the PHP docs get polished.

@alcaeus alcaeus merged commit 970d1d3 into mongodb:v1.18 Apr 23, 2024
15 checks passed
@alcaeus alcaeus deleted the fix-docs-syntax-error branch April 23, 2024 19:01
@mongodb-php-bot mongodb-php-bot mentioned this pull request Apr 23, 2024
Merged
alcaeus added a commit that referenced this pull request May 10, 2024
@alcaeus
Merge branch 'v1.18' into merge-v1.17-into-v1.18-1715326101426
76956d8 
* v1.18: (50 commits)
  Enable auto-merge in merge-up workflow (#1295)
  PHPLIB-1447: Add SBOM lite (#1292)
  Fix syntax error in docs (#1285)
  PHPLIB-1163 Create tutorial for using MongoDB with Bref (#1273) (#1282)
  Create sarif report when running psalm (#1280)
  Update composer.json and CI matrices for 1.18.0
  PHPLIB-1410: Invoke drivers-evergreen-tools scripts with bash (#1267)
  PHPLIB-1302: Use Composer\InstalledVersions (#1262)
  PHPLIB-1320: Support "comment" command option in Collection::createIndex() (#1263)
  PHPLIB-1413: Use env instead of matrix for driver-version (#1261)
  Fix Markdown heading
  PHPLIB-1399: Docs examples for agg expr projection (#1260)
  PHPLIB-1412: Skip range encryption tests on MongoDB 8.0+ (#1259)
  PHPLIB-1409: Skip $out and mapReduce tests on serverless (#1254)
  Exclude read-write-concern tests from serverless testing (#1253)
  PHPLIB-1409: Convert default write concern tests to unified test format (#1252)
  PHPLIB-1408: Convert ADL spec test to unified test format (#1250)
  Remove redundant annotations (#1251)
  PHPLIB-1404: Convert retryable reads spec tests to unified test format  (#1247)
  DOCSP-36627: Additional double backslash fixes for master (#1246)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikola jmikola jmikola approved these changes

@GromNaN GromNaN GromNaN approved these changes

Assignees

@alcaeus alcaeus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: missing ] character in database->aggregate documentation
3 participants
@alcaeus @jmikola @GromNaN