Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #793

Merged
merged 10 commits into from
Nov 6, 2020
Merged

PHP 8 support #793

merged 10 commits into from
Nov 6, 2020

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 4, 2020

This covers PHPLIB-595 and PHPLIB-588.

Due to PHP 8 not being available on Evergreen yet, we test standalone, replica set, and sharded topologies on PHP 8 as well, in addition to testing them on PHP 7.4. While a new version of the extension is required on PHP 8, we will not bump the minimum ext-mongodb version as existing versions should continue to work as expected.

Notable changes:

  • PHPUnit 9 moves the global assertions functions to a PHPUnit namespace. To provide compatibility with earlier PHPUnit versions (required to continue supporting PHP 7.0 and newer) we include a polyfill here which falls back to the PHPUnit functions if they exist.
  • travis-ci tested on PHP 7.3 by default. This was changed to PHP 7.4, including simplifying the configuration to make future changes easier (we expect to always test on the newest stable version)
  • The BC layer for constraints has been removed, as the changes were incorporated into the PHPUnit Bridge provided by Symfony. We'll update the dependency to a stable version once Symfony 5.2 has been released. Since it's a development dependency, using a branch version for it has no stability impact on users.

@alcaeus alcaeus self-assigned this Nov 4, 2020
@alcaeus alcaeus merged commit 78e3606 into mongodb:master Nov 6, 2020
@alcaeus alcaeus deleted the php-8-support branch November 6, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant