RUST-580 Improve compile times of the test suite #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
approved these changes
Jul 30, 2021
| fn execute_test_runner_operation<'a>( | ||
| &'a self, | ||
| _test_runner: &'a mut TestRunner, | ||
| ) -> BoxFuture<'a, ()> { |
There was a problem hiding this comment.
Does this (and likewise below) need a default body? It didn't have one before.
There was a problem hiding this comment.
They didn't have them previously because default implementations didn't place nicely with async_trait, see this comment for more info: https://github.com/mongodb/mongo-rust-driver/blob/master/src/test/spec/v2_runner/operation.rs#L43.
isabelatkinson
approved these changes
Jul 30, 2021
NBSquare
approved these changes
Jul 30, 2021
|
Yeah definitely, I updated the original issue and also filed one on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-580
This PR reimplements the various test runner
TestOperationtraits manually rather than relying onasync_trait, resulting in much faster compile times of the tests. For context, see rust-lang/rust#87012 (comment).On my machine, an incremental change to
TestClient::new(e.g. adding a singleprintln!) used to take ~1m15s to runcargo check --tests, whereas the same change now takes ~10s. There's still a lot of room for improvement (such a change should ideally be near instant), but this is still a big difference.