Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only attach error to diagnostics if podman machine is required #2783

Merged
merged 3 commits into from
Mar 19, 2024
Merged

fix: only attach error to diagnostics if podman machine is required #2783

merged 3 commits into from
Mar 19, 2024

Conversation

blva
Copy link
Collaborator

@blva blva commented Mar 19, 2024 •
edited
Loading

Proposed changes

Minor fix based on the missleading error that shows for linux users when we check diagnostics.

 "Errors": [

      "failed to detect podman machine: exit status 125: Error: cannot run command \"podman machine inspect\" as root"

    ]

  },

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review March 19, 2024 14:02
@blva blva requested a review from a team March 19, 2024 14:02
andreaangiolillo
andreaangiolillo previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gssbzn
gssbzn reviewed Mar 19, 2024
View reviewed changes
internal/podman/client.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit c296a2b into master Mar 19, 2024
17 checks passed
@blva blva deleted the fix-podman-machine-error branch March 19, 2024 16:06
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blva @gssbzn @andreaangiolillo @jeroenvervaeke