-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-69270:Backup: atlas snapshots create #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of small comments, nothing major, this looks great
func CreateBuilder() *cobra.Command { | ||
opts := &CreateOpts{} | ||
cmd := &cobra.Command{ | ||
Use: "create", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] can we add "take" as an alias to match the GUI?
} | ||
} | ||
|
||
// ContinuousSnapshots encapsulates the logic to manage different cloud providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ContinuousSnapshots encapsulates the logic to manage different cloud providers | |
// Snapshots encapsulates the logic to manage different cloud providers |
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-69270
Checklist
make fmt
and formatted my codeFurther comments