Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-69184: mongocli atlas networking peering create gcp #371

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Aug 18, 2020

Proposed changes

Jira ticket: CLOUDP-69184

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

$ mongocli atlas networking peering create gcp --atlasCidrBlock  192.168.0.0/16 --gcpProjectId scratch --network default  -o json
{
  "containerId": "5f3bf32a69b6e96e56fef47d",
  "id": "5f3bf3eb868f7b51b95dad27",
  "status": "ADDING_PEER",
  "gcpProjectId": "scratch",
  "networkName": "default"
}
$ mongocli atlas networking peering create gcp --atlasCidrBlock  192.168.0.0/16 --gcpProjectId scratch --network default  
Network peering connection '5f3bf3eb868f7b51b95dad27' created.

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/store/peering_connections.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 53f9f10 into master Aug 18, 2020
@gssbzn gssbzn deleted the CLOUDP-69184 branch August 18, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants