CLOUDP-69682: Add global API whitelist support #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| createWhitelist = "Create an access whitelist for Global API Key." | ||
| deleteWhitelist = "Delete a database user from Global API Key." | ||
| listWhitelist = "List Atlas whitelist entries for Global API Key." | ||
| describeEntry = "Return one Global Whitelist Entry using its unique identifier." |
There was a problem hiding this comment.
[np] given these are in the package, could just be "create/delete/list/describe"?
There was a problem hiding this comment.
they could, I've have issues in other packages of clash so I won't fix this here but feel free to improve on the idea, I even think we should consider getting rid of this file
| DeleteGlobalAPIKeyWhitelist(string) error | ||
| } | ||
|
|
||
| // GlobalAPIKeyWhitelists encapsulates the logic to manage different cloud providers |
andreaangiolillo
previously approved these changes
Aug 19, 2020
| const ( | ||
| short = "Manage the access whitelist for Global API Key." | ||
| createWhitelist = "Create an access whitelist for Global API Key." | ||
| deleteWhitelist = "Delete a database user from Global API Key." |
There was a problem hiding this comment.
Suggested change
| deleteWhitelist = "Delete a database user from Global API Key." | |
| deleteWhitelist = "Delete an access whitelist for Global API Key." |
There was a problem hiding this comment.
copy/pasta and wrong also in the original, thanks for catching this
gssbzn
commented
Aug 19, 2020
| @@ -67,7 +67,5 @@ func DeleteBuilder() *cobra.Command { | |||
|
|
|||
| cmd.Flags().StringVar(&opts.OrgID, flag.OrgID, "", usage.OrgID) | |||
|
|
|||
| _ = cmd.MarkFlagRequired(flag.Role) | |||
| @@ -16,6 +16,6 @@ package whitelist | |||
| const ( | |||
| short = "Manage the access whitelist for your API Key." | |||
| createWhitelist = "Create an access whitelist for your API Key." | |||
| deleteWhitelist = "Delete a database user from your API Key." | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-69682
Checklist
make fmtand formatted my codeFurther comments
List
$ mongocli iam globalWhitelist ls -o json { "results": [ { "id": "5f3cf81b89034c6b3c0a528e", "cidrBlock": "172.20.0.1", "created": "2020-08-19T16:13:13Z", "description": "CLI", "type": "GLOBAL_ROLE", "updated": "2020-08-19T16:13:13Z" } ], "links": [ { "rel": "self", "href": "http://mms:8080/api/public/v1.0/admin/whitelist?pageNum=1\u0026itemsPerPage=100" } ], "totalCount": 1 }Describe
Create
Delete