-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-70018: mongocli iam team(s) create #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a little suggestion to make the usage of the username a bit clearer since this can be a list and not a single user
internal/cli/iam/teams/create.go
Outdated
}, | ||
} | ||
|
||
cmd.Flags().StringSliceVar(&opts.userNames, flag.Username, []string{}, usage.Username) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have a different usage.Username
to explain this is a list of members of the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Jira ticket: CLOUDP-70018
Checklist
make fmt
and formatted my codeFurther comments
Got this error when running the command without username.
atlas
om