Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-72403: Update GOLANGCI_VERSION #423

Merged
merged 1 commit into from
Sep 8, 2020
Merged

CLOUDP-72403: Update GOLANGCI_VERSION #423

merged 1 commit into from
Sep 8, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Sep 8, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-72403

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

andreaangiolillo
andreaangiolillo approved these changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 9c88b44 into master Sep 8, 2020
@gssbzn gssbzn deleted the CLOUDP-72403 branch September 8, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @andreaangiolillo