CLOUDP-70048: mongocli atlas security ldap verify status

[andreaangiolillo]

Proposed changes

Jira ticket: CLOUDP-70048

Checklist

• I have signed the MongoDB CLA
• I have added tests that prove my fix is effective or that my feature works
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code

Further comments

./bin/mongocli atlas security ldap verify status 5f5b257f7476ce5785229ce4
REQUEST ID                 PROJECT ID                 STATUS
5f5b257f7476ce5785229ce4   5e4e593f70dfbf1010295836   FAILED

./bin/mongocli atlas security ldap verify status 5f5b257f7476ce5785229ce4 -o json
{
  "requestId": "5f5b257f7476ce5785229ce4",
  "groupId": "5e4e593f70dfbf1010295836",
  "request": {
    "hostname": "2.tcp.ngrok.io",
    "port": 19657,
    "bindUsername": "cn=admin,dc=example,dc=org"
  },
  "status": "FAILED",
  "validations": [
    {
      "status": "OK",
      "validationType": "SERVER_SPECIFIED"
    },
    {
      "status": "FAIL",
      "validationType": "CONNECT"
    }
  ],
  "links": [
    {
      "rel": "self",
      "href": "https://cloud-dev.mongodb.com/api/atlas/v1.0/groups/5e4e593f70dfbf1010295836/userSecurity/ldap/verify/5f5b257f7476ce5785229ce4"
    }
  ]
}

[andreaangiolillo]

@gssbzn tagging you here so you can review this PR once you're back.

[colm-quinn]

LGTM, however it looks like you've broken the tests with parameter changes.

EDIT: NM, you fixed it while I was reviewing :D

[andreaangiolillo]

Thanks for the review!! 🚀

Regarding your question that I don’t see anymore:

Those usage parameters have been added yesterday here #437, so nobody is using them. In addition this change was requested by @gssbzn #437 (comment)

[colm-quinn]

Thanks for the review!! 🚀

Regarding your question that I don’t see anymore:

Those usage parameters have been added yesterday here #437, so nobody is using them. In addition this change was requested by @gssbzn #437 (comment)

Yup, I had figured out the parameters myself going back over the blame on the file, then deleted the comment :) Thanks for the detail