Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-70052: mongocli atlas security ldap delete|rm #441

Merged
merged 5 commits into from
Sep 11, 2020
Merged

CLOUDP-70052: mongocli atlas security ldap delete|rm #441

merged 5 commits into from
Sep 11, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 11, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-70052

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli atlas security ldap delete
? Are you sure you want to delete:  Yes
LDAP configuration userToDNMapping deleted from '5e4e593f70dfbf1010295836'

@andreaangiolillo
Copy link
Collaborator Author

andreaangiolillo commented Sep 11, 2020 •
edited
Loading

@gssbzn tagging you here if you want to review this once you're back

colm-quinn
colm-quinn approved these changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 3f42237 into master Sep 11, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-70052 branch September 11, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @colm-quinn