Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-69429: Cloud Services Milestone: Custom DNS AWS #453

Merged
merged 12 commits into from
Sep 23, 2020
Merged

CLOUDP-69429: Cloud Services Milestone: Custom DNS AWS #453

merged 12 commits into from
Sep 23, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 23, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-69429

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli atlas customDns aws enable
DNS configuration enabled.

./bin/mongocli atlas customDns aws describe
ENABLED
true

./bin/mongocli atlas customDns aws disable
DNS configuration disabled.


./bin/mongocli atlas customDns aws describe
ENABLED
false

gssbzn
gssbzn requested changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, a couple of suggestions but none blocking the only main thing is it looks like you forgot the output flag for all the commands

internal/cli/atlas/customdns/aws/describe.go Outdated Show resolved Hide resolved
internal/cli/atlas/customdns/aws/describe.go Show resolved Hide resolved
internal/store/custom_dns.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for all the improvements

@andreaangiolillo andreaangiolillo merged commit db601e8 into master Sep 23, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-69429 branch September 23, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn