Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-73988: Fix version manifest update command to use the static endpoint #469

Merged
merged 4 commits into from
Sep 30, 2020
Merged

CLOUDP-73988: Fix version manifest update command to use the static endpoint #469

merged 4 commits into from
Sep 30, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 30, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-73988

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om versionManifest update 4.4 -P ops -o json
{
  "updated": 1599868800044,
  "versions": [
    {
      "name": "2.6.0",
      "builds": [
        {
          "architecture": "amd64",
          "gitVersion": "1c1c76aeca21c5983dc178920f5052c298db616c",
          "platform": "linux",
          "url": "/linux/mongodb-linux-x86_64-2.6.0.tgz"
        },
....

gssbzn
gssbzn requested changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor thing to move the definition of the base url to the store package

internal/cli/opsmanager/versionmanifest/update.go Outdated Show resolved Hide resolved
internal/store/store.go Outdated
@@ -200,6 +200,23 @@ func NewUnauthenticated(c Config) (*Store, error) {

return s, nil
}
func NewStaticPath(c Config, baseURL string) (*Store, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related to my previous comment, baseURL belongs in this package, it will also be nice if we can parameterize this via the config object but not necessary right now

gssbzn
gssbzn approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for adding the ability to set a custom manifest path

internal/config/const.go
baseURL = "base_url"
opsManagerCACertificate = "ops_manager_ca_certificate"
opsManagerSkipVerify = "ops_manager_skip_verify"
opsManagerVersionManifestURL = "ops_manager_version_manifest_url"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

internal/store/store.go
@@ -200,6 +202,27 @@ func NewUnauthenticated(c Config) (*Store, error) {

return s, nil
}
func NewStaticPath(c Config) (*Store, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] missing new line here but we can fix later

@andreaangiolillo andreaangiolillo merged commit a2f3548 into master Sep 30, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-73988 branch September 30, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn