Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-73728: mongocli ops-manager admin backup s3 lists #487

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 12, 2020

Proposed changes

Jira ticket: CLOUDP-73728

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om admin backup s3 list -P ops
ID                         URI                         SSL     LOAD FACTOR   S3 AUTH METHOD
andrea.angiolillo.bucket   mongodb://127.0.0.1:27017   false   50            KEYS
./bin/mongocli om admin backup s3 list -P ops -o json
{
  "links": [
    {
      "rel": "self",
      "href": "http://localhost:8080/api/public/v1.0/admin/backup/snapshot/s3Configs?pageNum=1\u0026itemsPerPage=100"
    }
  ],
  "results": [
    {
      "id": "andrea.angiolillo.bucket",
      "uri": "mongodb://127.0.0.1:27017",
      "writeConcern": "ACKNOWLEDGED",
      "ssl": false,
      "assignmentEnabled": true,
      "encryptedCredentials": false,
      "loadFactor": 50,
      "awsAccessKey": "XXXXXXXXXX",
      "awsSecretKey": "XXXXXX",
      "s3AuthMethod": "KEYS",
      "s3BucketEndpoint": "s3-eu-west-1.amazonaws.com",
      "s3BucketName": "andrea.angiolillo.bucket",
      "s3MaxConnections": 50,
      "disableProxyS3": true,
      "acceptedTos": true,
      "sseEnabled": false,
      "pathStyleAccessEnabled": false
    }
  ],
  "totalCount": 1
}

@andreaangiolillo andreaangiolillo marked this pull request as ready for review October 12, 2020 12:52
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"github.com/spf13/cobra"
)

var listTemplate = `ID URI SSL LOAD FACTOR S3 AUTH METHOD{{range .Results}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non blocking] could be just AUTH METHOD given the scope of the command but I don't feel strong about it

Suggested change
var listTemplate = `ID URI SSL LOAD FACTOR S3 AUTH METHOD{{range .Results}}
var listTemplate = `ID URI SSL LOAD FACTOR AUTH METHOD{{range .Results}}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to change this in the next command

@andreaangiolillo andreaangiolillo merged commit c1d0884 into master Oct 12, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-73728 branch October 12, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants