Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-73748 mongocli ops-manager serverUsage download, CLOUDP-73749: mongocli ops-manager serverUsage capture #501

Merged
merged 10 commits into from
Oct 19, 2020
Merged

CLOUDP-73748 mongocli ops-manager serverUsage download, CLOUDP-73749: mongocli ops-manager serverUsage capture #501

merged 10 commits into from
Oct 19, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 16, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-73748
Jira ticket: CLOUDP-73749

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om serverUsage capture -P ops
Snapshot captured

./bin/mongocli om serverUsage download --startDate "2020-01-01" --endDate "2020-10-16" -P ops
Download of serverUsageReport.tar.gz completed.

Screenshot 2020-10-16 at 17 46 05

gssbzn
gssbzn requested changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newServerTypeOptions doesn't look to be setting the format query param

gssbzn
gssbzn requested changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small nits on generating the file name

internal/usage/usage.go Outdated Show resolved Hide resolved
internal/cli/opsmanager/serverusage/download.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry about all the little changes

@andreaangiolillo
Copy link
Collaborator Author

Not at all! Thanks for your review!

@andreaangiolillo andreaangiolillo merged commit bb2a215 into master Oct 19, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-73748 branch October 19, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn