Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-75270: Replace atlas.ProjectIPWhitelist with ProjectIPAccessList #503

Merged
merged 5 commits into from
Oct 19, 2020
Merged

CLOUDP-75270: Replace atlas.ProjectIPWhitelist with ProjectIPAccessList #503

merged 5 commits into from
Oct 19, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Oct 19, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-75270

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

gssbzn
gssbzn requested changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit

internal/store/project_ip_access_lists.go Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 023747d into master Oct 19, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-75270 branch October 19, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn