Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-77515: [mongocli] update atlas and ops manager clients #529

Merged
merged 1 commit into from
Nov 23, 2020
Merged

CLOUDP-77515: [mongocli] update atlas and ops manager clients #529

merged 1 commit into from
Nov 23, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Nov 23, 2020

Proposed changes

Jira ticket: CLOUDP-77515

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

This needed some manual intervention as the atlas client introduced some breaking changes

andreaangiolillo
andreaangiolillo approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

threebee
threebee approved these changes Nov 23, 2020
View reviewed changes
Copy link

@threebee threebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gssbzn gssbzn merged commit 6ac5da4 into master Nov 23, 2020
@gssbzn gssbzn deleted the CLOUDP-77515 branch November 23, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threebee threebee threebee approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gssbzn @threebee @andreaangiolillo