CLOUDP-82912: annotations to avoid removing resources from Atlas #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 19, 2021 17:45
…to CLOUDP-82912_cleanup-annotations
…to CLOUDP-82912_cleanup-annotations
vasilevp
reviewed
Apr 23, 2021
| Expect(k8sClient.Delete(context.Background(), createdProject)).To(Succeed()) | ||
| time.Sleep(10 * time.Second) | ||
| Expect(checkAtlasProjectRemoved(createdProject.Status.ID)()).Should(BeFalse()) | ||
| createdProject = nil |
There was a problem hiding this comment.
[q] shouldn't we remove this project from Atlas to keep it cleaner?
There was a problem hiding this comment.
I thought the project cleaner will do it but better do manually, right 👍
added 2 commits
April 26, 2021 10:03
leo-ri
approved these changes
Apr 27, 2021
…to CLOUDP-82912_cleanup-annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for annotations of type
mongodb.com/atlas-resource-policy="keep"When set to any CR it will tell the AO to skip removal of the resource in Atlas when the K8s resource is removed.
Note, that the connection secrets are still removed in this case