Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-87735: global secret configuration #222

Merged
merged 4 commits into from
May 6, 2021

Conversation

antonlisovenko
Copy link
Contributor

@antonlisovenko antonlisovenko commented Apr 30, 2021

This PR allows the user to override the global API key Secret by passing the global-api-secret-name argument to the container. If the flag not provided - the name defaults to the <deployment_name>-api-key

As this cannot be tested by integration tests I've tested this manually: changed the deployment spec to the following:

- args:
          - --atlas-domain=https://cloud-qa.mongodb.com
          - --health-probe-bind-address=:8081
          - --metrics-bind-address=127.0.0.1:8080
          - --leader-elect
          - --global-api-secret-name=the-global-key
          command:
          - /manager

and ensured, that the new Secret was used by the Operator instead of the default one

@antonlisovenko antonlisovenko marked this pull request as ready for review April 30, 2021 12:24
@antonlisovenko antonlisovenko merged commit dbf4ae9 into main May 6, 2021
@antonlisovenko antonlisovenko deleted the CLOUDP-87735_global-secret-configuration branch May 6, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants