MOTOR-897 Set up flake8 #146
Conversation
motor/core.py
Outdated
| @@ -34,7 +33,7 @@ | |||
| from pymongo.driver_info import DriverInfo | |||
| from pymongo.encryption import ClientEncryption | |||
|
|
|||
| from motor.docstrings import * | |||
| import motor.docstrings as docstrings | |||
There was a problem hiding this comment.
from motor import docstrings?
| @@ -298,21 +298,15 @@ def __new__(mcls, name, _bases, attrs): | |||
| return type.__new__(_metaclass, str("dummy"), (), {}) | |||
|
|
|||
|
|
|||
| class Synchro(with_metaclass(SynchroMeta)): | |||
There was a problem hiding this comment.
Can we also remove with_metaclass now?
There was a problem hiding this comment.
These changes cause this error in the synchro tests:
[2022/02/17 01:40:50.485] Traceback (most recent call last):
[2022/02/17 01:40:50.485] File "/opt/python/3.7/lib/python3.7/runpy.py", line 183, in _run_module_as_main
[2022/02/17 01:40:50.485] mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
[2022/02/17 01:40:50.485] File "/opt/python/3.7/lib/python3.7/runpy.py", line 109, in _get_module_details
[2022/02/17 01:40:50.485] __import__(pkg_name)
[2022/02/17 01:40:50.485] File "/data/mci/25c39eae21d0be14b9a9ad83b5be38eb/src/synchro/__init__.py", line 291, in <module>
[2022/02/17 01:40:50.485] class Synchro(meta=SynchroMeta):
[2022/02/17 01:40:50.485] TypeError: __init_subclass__() takes no keyword arguments
There was a problem hiding this comment.
Fixed, used the wrong argument name
synchro/__init__.py
Outdated
| @@ -424,7 +418,7 @@ def __exit__(self, exc_type, exc_val, exc_tb): | |||
| self.synchronize(self.delegate.end_session) | |||
|
|
|||
| def with_transaction(self, *args, **kwargs): | |||
| raise unittest.SkipTest("MOTOR-606 Synchro does not support " "with_transaction") | |||
| raise unittest.SkipTest("MOTOR-606 Synchro does not supportwith_transaction") | |||
synchro/__init__.py
Outdated
| @@ -618,7 +612,7 @@ def __init__(self, delegate): | |||
| super().__init__(delegate) | |||
|
|
|||
| def next(self): | |||
| motor_grid_out = super().next() | |||
| motor_grid_out = next(super()) | |||
There was a problem hiding this comment.
B305 `.next()` is not a thing on Python 3. Use the `next()` builtin. For Python 2 compatibility, use `six.next()`.
There was a problem hiding this comment.
But Cursor.next() it is a thing in pymongo. That's what's confusing to me. I think we should disable this check as long as we support next() methods.
There was a problem hiding this comment.
Yeah I'll disable B305 globally here as well.
| @@ -298,21 +298,15 @@ def __new__(mcls, name, _bases, attrs): | |||
| return type.__new__(_metaclass, str("dummy"), (), {}) | |||
|
|
|||
|
|
|||
| class Synchro(with_metaclass(SynchroMeta)): | |||
There was a problem hiding this comment.
These changes cause this error in the synchro tests:
[2022/02/17 01:40:50.485] Traceback (most recent call last):
[2022/02/17 01:40:50.485] File "/opt/python/3.7/lib/python3.7/runpy.py", line 183, in _run_module_as_main
[2022/02/17 01:40:50.485] mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
[2022/02/17 01:40:50.485] File "/opt/python/3.7/lib/python3.7/runpy.py", line 109, in _get_module_details
[2022/02/17 01:40:50.485] __import__(pkg_name)
[2022/02/17 01:40:50.485] File "/data/mci/25c39eae21d0be14b9a9ad83b5be38eb/src/synchro/__init__.py", line 291, in <module>
[2022/02/17 01:40:50.485] class Synchro(meta=SynchroMeta):
[2022/02/17 01:40:50.485] TypeError: __init_subclass__() takes no keyword arguments
|
Waiting for the synchro task to complete. |
|
Looks like we're out of synch on parameters: |
|
Yes that's expected. I just wanted to make sure that the synchro tests fail in the same way as before. |
No description provided.