Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first pass removing unneeded deps #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

first pass removing unneeded deps #54

wants to merge 6 commits into from

Conversation

schmalliso
Copy link
Contributor

I don't think I broke anything but also we have very few tests in this repo 😭.

@schmalliso schmalliso requested a review from i80and March 15, 2023 20:10
@i80and
Copy link
Collaborator

i80and commented Mar 15, 2023

no new type errors, and all the scripts run! lgtm!

If we drop the intersphinx and convert_redirects scripts, which I believe are unused, we can also drop pyyaml too!

@schmalliso schmalliso requested a review from i80and March 16, 2023 16:13
i80and
i80and approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@i80and i80and left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i80and i80and i80and approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmalliso @i80and