fix(changeStreams): fixing node4 issue with util.inherits #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
require('util').inherits(ctor, super) blows away the original prototype
of ctor. If we wish to use it, we need to move the inherits call to
directly after the constructor creation. In the future, we should
switch to using classes.
mbroadst
approved these changes
Nov 29, 2017
jlord
approved these changes
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require('util').inherits(ctor, super)blows away the original prototypeof ctor. If we wish to use it, we need to move the inherits call to
directly after the constructor creation. In the future, we should
switch to using classes.