feat(cryptdConnectionString): makes mongocryptd uri configurable #2049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosemaryy
requested review from
mbroadst,
daprahamian,
kvwalker and
spal1
and removed request for
mbroadst and
daprahamian
mbroadst
suggested changes
Jul 2, 2019
There was a problem hiding this comment.
Hi @rosemaryy, two comments:
- I don't think this change is performance related, I think you might want to call this a
feat - The options for client-side field-level encryption are all represented in the autoEncryption option. We should adhere to the spec when it comes to setting options related to
mongocryptd
daprahamian
suggested changes
Jul 2, 2019
rosemaryy
changed the title
daprahamian
suggested changes
Jul 2, 2019
mbroadst
reviewed
Jul 2, 2019
kvwalker
reviewed
Jul 3, 2019
daprahamian
pushed a commit
that referenced
this pull request
Aug 13, 2019
* perf(cryptdConnectionString): make mongocryptd uri configurable by creating the property `autoEncryption.extraOptions.mongocryptURI` Fixes NODE-2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NODE-2012
Description
Previously, cryptd's connectionString was not configurable. Now, the user has the option of setting connectionString by passing it in as an option for MongoClient.
What changed?
cryptdConnectionString is now a valid option for MongoClient