fix(ClientSession): correct toBSON TypeScript signature #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a tiny thing I happened to notice. :)
|
Tracked in https://jira.mongodb.org/browse/NODE-2991 |
|
@agolin95 Just for the future, your team prefers to have JIRA tickets for every PR? |
|
Hi @addaleax, thanks for asking! We use Jira as our primary source of truth so it would be ideal to have a ticket for any PRs to make them easier to catch in our meetings and on our boards. |
nbbeeken
approved these changes
Jan 11, 2021
emadum
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny thing I happened to notice. :)