Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-2899): sort and correct circular imports #3072

Merged
merged 7 commits into from
Dec 13, 2021
Merged

fix(NODE-2899): sort and correct circular imports #3072

merged 7 commits into from
Dec 13, 2021

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Dec 7, 2021 •
edited
Loading

Description

What is changing?

  • A number of constants are moved to a shared leaf module.
  • moved commandSupportsReadConcern to utils.ts for sharing
  • Auth providers map can be defined inside the only module that uses it
  • changed the defaultAuthProviders file name, it was the only camelcase one
  • sorted all the imports and added that to our linting
  • added testing to make sure each file can be imported on its own

What is the motivation for this change?

Imports are sorted, and we are checking to be sure circular dependency issues aren't reintroduced.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Flakey test discovered: https://jira.mongodb.org/browse/NODE-3808

@nbbeeken nbbeeken marked this pull request as ready for review December 7, 2021 21:39
durran
durran previously approved these changes Dec 8, 2021
View reviewed changes
@durran durran added the Team Review Needs review from team label Dec 8, 2021
@nbbeeken nbbeeken force-pushed the NODE-2899/sort-imports branch 2 times, most recently from 664c6b6 to e7905e9 Compare December 13, 2021 15:15
@dariakp dariakp added the Blocked Blocked on other work label Dec 13, 2021
@dariakp
Copy link
Contributor

dariakp commented Dec 13, 2021

Note: Marking blocked on the merge of our two outstanding feature PRs

@dariakp dariakp removed the Blocked Blocked on other work label Dec 13, 2021
@dariakp
Copy link
Contributor

dariakp commented Dec 13, 2021

Removing blocked label since the feature PR went in (and we shouldn't need to worry about this for the dot notation one); just needs a rebase before re-review and merge

dariakp
dariakp approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm

@dariakp dariakp merged commit 48cc729 into main Dec 13, 2021
@dariakp dariakp deleted the NODE-2899/sort-imports branch December 13, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariakp dariakp dariakp approved these changes

@durran durran durran left review comments

@baileympearson baileympearson Awaiting requested review from baileympearson

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @dariakp @durran